Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - Fix Broken Links and List Ordering #307

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[Bug] - Fix Broken Links and List Ordering #307

merged 2 commits into from
Aug 10, 2023

Conversation

krishnasvp
Copy link
Contributor

@krishnasvp krishnasvp commented Aug 3, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    /kind bug

  • What this PR does / why we need it:

  • Fixes broken links across the website

  • Fixes typos and other grammatical erros

  • Which issue(s) this PR fixes:

  • Fixes - [Bug] - Broken Links in the Docs #305

@krishnasvp
Fixed Bugs Related to Broken Links, Typos
ca9f3e2 
Signed-off-by: Krishna Sivapothanathan <krishnasivapothanathan@gmail.com>
@krishnasvp
Fixes - volcano-sh#305
bd48dfe 
Signed-off-by: Krishna Sivapothanathan <krishnasivapothanathan@gmail.com>
@volcano-sh-bot
Copy link
Collaborator

@krishnasvp: The label(s) kind/**what, kind/this, kind/pr, kind/does, kind//, kind/why, kind/we, kind/need, kind/it**: cannot be applied. These labels are supported: ``

In response to this:

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    /kind

  • What this PR does / why we need it:

  • Fixes broken links across the website

  • Fixes typos and other grammatical erros

  • Which issue(s) this PR fixes:

  • Fixes - [Bug] - Broken Links in the Docs #305

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot requested review from k82cn and Thor-wl August 3, 2023 19:34
@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2023
@krishnasvp
Copy link
Contributor Author

/assign

hwdef
hwdef reviewed Aug 4, 2023
View reviewed changes
@hwdef
Copy link
Member

hwdef commented Aug 4, 2023

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
Arhell
Arhell reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kevin-wangzefeng
kevin-wangzefeng approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@volcano-sh-bot volcano-sh-bot merged commit 2970801 into volcano-sh:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Arhell Arhell Arhell left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

Assignees

@kevin-wangzefeng kevin-wangzefeng

@hwdef hwdef

@krishnasvp krishnasvp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krishnasvp @volcano-sh-bot @hwdef @kevin-wangzefeng @Arhell